New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(edgeless): connector supports text label #6665
base: master
Are you sure you want to change the base?
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
1 Ignored Deployment
|
Your org has enabled the Graphite merge queue for merging into masterAdd the label “merge” to the PR and Graphite will automatically add it to the merge queue when it’s ready to merge. You must have a Graphite account in order to use the merge queue. Sign up using this link. |
This stack of pull requests is managed by Graphite. Learn more about stacking. |
285e051
to
ab88111
Compare
ab88111
to
8ab5a54
Compare
8ab5a54
to
db17c46
Compare
f6466ad
to
f18bc19
Compare
ed51e0b
to
3cc6656
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The data structure updates should be listed in PR description.
I think Connector Label should be a standalone element to support selection, adjusting styles, dragging and dropping to move the position, adjusting the index. |
3cc6656
to
ee29c2c
Compare
Is there any special with connector text comparing to shape text? |
|
73738e9
to
7ed6162
Compare
7ed6162
to
4aede2e
Compare
247357c
to
b0a07ac
Compare
b0a07ac
to
7389fc0
Compare
The connector supports text label.
There are three modes in connector:
Straight
Orthogonal
Curve
, need to be handled separately.Connector Label
connector
label
font
,color
front
back
Label
, and pressDelete
Connector
andLabel
, and pressDelete
orCMD+A
+Delete
Connector
, and pressDelete
,Label
will also be deletedshould only show the connector's toolbar
shift+
click)Updates
This will be split into smaller PRs.