Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(blocks): file drop manager supports files from other apps #7013

Merged
merged 1 commit into from May 22, 2024
Merged

feat(blocks): file drop manager supports files from other apps #7013

merged 1 commit into from May 22, 2024

Conversation

fundon
Copy link
Contributor

@fundon fundon commented May 10, 2024 •
edited

Currently Simple supports files from other apps.
If we want a better experience, we can follow the RFC File Drop Manager to improve it.

Screen.Recording.2024-05-10.at.22.20.12.mov

@vercel Vercel
Copy link

vercel bot commented May 10, 2024 •
edited

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
blocksuite ❌ Failed (Inspect) May 22, 2024 8:18am
1 Ignored Deployment
Name Status Preview Comments Updated (UTC)
blocksuite-docs ⬜️ Ignored (Inspect) Visit Preview May 22, 2024 8:18am

@graphite-app Graphite App
Copy link

graphite-app bot commented May 10, 2024

Your org has enabled the Graphite merge queue for merging into master

Add the label “merge” to the PR and Graphite will automatically add it to the merge queue when it’s ready to merge.

You must have a Graphite account and log in to Graphite in order to use the merge queue. Sign up using this link.

@fundon Graphite App
Copy link
Contributor Author

fundon commented May 10, 2024

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @fundon and the rest of your teammates on Graphite Graphite

@fundon fundon force-pushed the 05_10-feat-file-drop-manager-supports-files-from-other-software branch 2 times, most recently from 8b27abb to 9e4c95d Compare May 10, 2024 14:16
@fundon fundon marked this pull request as ready for review May 10, 2024 14:21
@fundon fundon requested a review from EYHN May 10, 2024 14:21
@fundon fundon force-pushed the 05_10-feat-file-drop-manager-supports-files-from-other-software branch 3 times, most recently from ac1afe0 to 79e68ad Compare May 10, 2024 14:26
@fundon fundon force-pushed the 05_10-feat-file-drop-manager-supports-files-from-other-software branch 2 times, most recently from 7c469aa to 78311d5 Compare May 10, 2024 14:41
@fundon fundon force-pushed the 05_10-feat-file-drop-manager-supports-files-from-other-software branch from 78311d5 to f57d3c4 Compare May 11, 2024 20:07
@fundon fundon force-pushed the 05_10-feat-file-drop-manager-supports-files-from-other-software branch from f57d3c4 to 27a3f98 Compare May 13, 2024 01:21
@fundon fundon marked this pull request as draft May 13, 2024 02:37
@fundon fundon changed the title feat(blocks): file drop manager supports files from other software feat(blocks): file drop manager supports files from other apps May 13, 2024
@fundon fundon force-pushed the 05_10-feat-file-drop-manager-supports-files-from-other-software branch 2 times, most recently from f66b67d to 9f39521 Compare May 13, 2024 12:01
@fundon fundon marked this pull request as ready for review May 13, 2024 12:05
@fundon fundon force-pushed the 05_10-feat-file-drop-manager-supports-files-from-other-software branch from 6202067 to e45a0af Compare May 14, 2024 01:37
@fundon fundon force-pushed the 05_10-feat-file-drop-manager-supports-files-from-other-software branch from e45a0af to 669e283 Compare May 14, 2024 01:47
@fundon fundon force-pushed the 05_10-feat-file-drop-manager-supports-files-from-other-software branch from 669e283 to e5207cb Compare May 14, 2024 02:00
@fundon fundon force-pushed the 05_10-feat-file-drop-manager-supports-files-from-other-software branch from e5207cb to cad688e Compare May 14, 2024 02:10
Saul-Mirone
Saul-Mirone requested changes May 14, 2024
View reviewed changes
Copy link
Collaborator

@Saul-Mirone Saul-Mirone left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You should use adapter together with transformer.

@fundon fundon marked this pull request as draft May 14, 2024 03:59
@fundon fundon force-pushed the 05_10-feat-file-drop-manager-supports-files-from-other-software branch from cad688e to 2a2e782 Compare May 21, 2024 17:00
@fundon fundon force-pushed the 05_10-feat-file-drop-manager-supports-files-from-other-software branch from 2a2e782 to fe3418d Compare May 21, 2024 17:01
@fundon fundon marked this pull request as ready for review May 21, 2024 17:02
@fundon fundon requested a review from Saul-Mirone May 21, 2024 17:02
@fundon
Copy link
Contributor Author

fundon commented May 21, 2024

Currently only files entry is supported.

@fundon fundon added the merge label May 22, 2024
@graphite-app Graphite App
Copy link

graphite-app bot commented May 22, 2024 •
edited

Merge activity

  • May 22, 2:10 AM EDT: The merge label 'merge' was detected. This PR will be added to the Graphite merge queue once it meets the requirements.
  • May 22, 4:16 AM EDT: fundon added this pull request to the Graphite merge queue.
  • May 22, 4:25 AM EDT: fundon merged this pull request with the Graphite merge queue.

@fundon fundon force-pushed the 05_10-feat-file-drop-manager-supports-files-from-other-software branch from fe3418d to c023ce8 Compare May 22, 2024 06:14
@fundon
feat(blocks): file drop manager supports files from other apps (#7013)
d747ad3 
Currently Simple supports files from other apps.
If we want a better experience, we can follow the RFC `File Drop Manager` to improve it.

https://github.com/toeverything/blocksuite/assets/27926/8a6375d7-9df6-4f15-b11f-7174e3dc01e8
@fundon fundon force-pushed the 05_10-feat-file-drop-manager-supports-files-from-other-software branch from c023ce8 to d747ad3 Compare May 22, 2024 08:17
@graphite-app graphite-app bot merged commit d747ad3 into master May 22, 2024
18 of 19 checks passed
@graphite-app graphite-app bot deleted the 05_10-feat-file-drop-manager-supports-files-from-other-software branch May 22, 2024 08:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Saul-Mirone Saul-Mirone Saul-Mirone approved these changes

@fourdim fourdim fourdim approved these changes

@doodlewind doodlewind Awaiting requested review from doodlewind

@EYHN EYHN Awaiting requested review from EYHN

@donteatfriedrice donteatfriedrice Awaiting requested review from donteatfriedrice

Assignees
No one assigned
Labels
merge
Projects
BlockSuite Project
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@fundon @Saul-Mirone @fourdim