Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Breaking: replaced :include_expired and :only_expired in query filters with :status #2

Merged
merged 3 commits into from
Mar 21, 2023
Merged

Breaking: replaced :include_expired and :only_expired in query filters with :status #2

merged 3 commits into from
Mar 21, 2023

Conversation

tofran
Copy link
Owner

@tofran tofran commented Mar 21, 2023

This is a breaking change. Note that only_expired did not work as intended.

Example with status:

Sessions.count(status: :all)
Sessions.count(status: :valid)
Sessions.count(status: :expired)

To demo this added a new page /stats in the demo project.

@tofran tofran merged commit 3aec54f into main Mar 21, 2023
@tofran tofran deleted the filters-fix-and-demo-stats branch March 22, 2023 00:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
1 participant
@tofran