Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: update actions/checkout and Swatinem/rust-cache actions #34

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

taiki-e
Copy link
Member

@taiki-e taiki-e commented Jan 7, 2024

No description provided.

@taiki-e
Copy link
Member Author

taiki-e commented Jan 7, 2024

CI failures are:

doctest failure: https://github.com/tokio-rs/async-backtrace/actions/runs/7439947852/job/20240413980

test backtrace/src/location.rs - location::location (line 7) ... FAILED

failures:

---- backtrace/src/location.rs - location::location (line 7) stdout ----
Test executable failed (exit status: 101).

stderr:
thread 'main' panicked at backtrace/src/location.rs:9:5:
assertion `left == right` failed
  left: 61
 right: 51

And new clippy warnings: https://github.com/tokio-rs/async-backtrace/actions/runs/7439947852/job/20240413550

error: this bound is already specified as the supertrait of `FusedIterator`
   --> backtrace/src/frame.rs:367:37
    |
367 |     pub fn backtrace(&self) -> impl Iterator<Item = &Frame> + FusedIterator {
    |                                     ^^^^^^^^^^^^^^^^^^^^^^^
    |
    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#implied_bounds_in_impls
    = note: `-D clippy::implied-bounds-in-impls` implied by `-D warnings`
    = help: to override `-D warnings` add `#[allow(clippy::implied_bounds_in_impls)]`
help: try removing this bound
    |
367 -     pub fn backtrace(&self) -> impl Iterator<Item = &Frame> + FusedIterator {
367 +     pub fn backtrace(&self) -> impl FusedIterator<Item = &Frame> {
    |

error: this bound is already specified as the supertrait of `FusedIterator`
   --> backtrace/src/frame.rs:402:51
    |
402 |     pub(crate) unsafe fn subframes(&self) -> impl Iterator<Item = &Frame> + FusedIterator {
    |                                                   ^^^^^^^^^^^^^^^^^^^^^^^
    |
    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#implied_bounds_in_impls
help: try removing this bound
    |
402 -     pub(crate) unsafe fn subframes(&self) -> impl Iterator<Item = &Frame> + FusedIterator {
402 +     pub(crate) unsafe fn subframes(&self) -> impl FusedIterator<Item = &Frame> {
    |

The latter is easy to fix, but I'm not sure what the former is.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant