Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add MethodRouter::{into_make_service, into_make_service_with_connect_info} #1010

Merged
merged 3 commits into from May 8, 2022
Merged

Add MethodRouter::{into_make_service, into_make_service_with_connect_info} #1010

merged 3 commits into from May 8, 2022

Conversation

davidpdrsn
Copy link
Member

These methods existed on Router and Handler but not on MethodRouter. For consistency I think it makes sense to provide.

@davidpdrsn davidpdrsn requested a review from jplatte May 8, 2022 14:52
@davidpdrsn davidpdrsn merged commit a3a32f4 into main May 8, 2022
@davidpdrsn davidpdrsn deleted the method-router-into-make-service branch May 8, 2022 17:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jplatte jplatte jplatte approved these changes

Assignees
No one assigned
Labels
A-axum
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@davidpdrsn @jplatte