Add protocol field to WebSocket #1022
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Matteo Joliveau <matteojoliveau@gmail.com>
davidpdrsn
requested changes
May 10, 2022
Signed-off-by: Matteo Joliveau <matteojoliveau@gmail.com>
jplatte
reviewed
May 10, 2022
Co-authored-by: Jonas Platte <jplatte+git@posteo.de>
davidpdrsn
reviewed
May 11, 2022
jplatte
approved these changes
May 11, 2022
|
@davidpdrsn changelog updated! |
davidpdrsn
approved these changes
May 11, 2022
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Matteo Joliveau matteojoliveau@gmail.com
Closes #1020
I used
String::from_utf8_lossybecause I didn't want to add complex error handling for a corner case (non-UTF8 characters in an HTTP header) that, for this particular use-case, is pretty rare. I would have loved to use aCowinstead of aStringinside ofWebSocketto avoid an allocation, but I had a bit of a hard time fighting with lifetimes so I eventually conceded.Feedbacks and suggestions welcome!