Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support Path<Vec<(String, String)>> #1059

Merged
merged 2 commits into from May 27, 2022
Merged

Support Path<Vec<(String, String)>> #1059

merged 2 commits into from May 27, 2022

Conversation

davidpdrsn
Copy link
Member

We mentioned using Path<Vec<(String, String)>> to get key/value pairs in the docs but it didn't work at all 馃う Was probably just wishful thinking 馃槄

However this makes it work!

Fixes #1057

@davidpdrsn davidpdrsn requested a review from jplatte May 27, 2022 10:06
@davidpdrsn davidpdrsn mentioned this pull request May 27, 2022
Closed
jplatte
jplatte approved these changes May 27, 2022
View reviewed changes
Copy link
Member

@jplatte jplatte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks like path/de.rs doesn't have a test for the (probably more important) Vec<String>, but otherwise LGTM.

@davidpdrsn davidpdrsn merged commit 6c10f41 into main May 27, 2022
@davidpdrsn davidpdrsn deleted the path-key-value-pairs branch May 27, 2022 12:11
@davidpdrsn
Copy link
Member Author

@jplatte it well hidden but we have https://github.com/tokio-rs/axum/blob/main/axum/src/extract/path/de.rs#L707-L711

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jplatte jplatte jplatte approved these changes

Assignees
No one assigned
Labels
A-axum
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Possible bug in documentation of axum::extract::Path
2 participants
@davidpdrsn @jplatte