Support running extractors from middleware::from_fn
#1088
Merged
+154
−61
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Lately we've had a few people ask about how run extractors from middleware. This was previously possible by building your own
RequestParts
and then running the extractor. But this adds support tomiddleware::from_fn
to just support extractors directly. I think that is quite clean and doesn't require any new API.It means if people are writing a middleware by implementing
Service
themselves then they still have to do it withRequestParts
. I don't think thats too bad but we can always consider improving that in the future. I still think this change makes sense on its own though.Its a breaking change because some type params and bounds changed.
Supersedes #1083