Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Router
is cloned once for every request inIntoMakeService::call
so ideally it should be cheap to do so.Solution
Wrap the
Node
in aArc
and rebuild it when callingRouter::router
. This is fine since it only happens during startup.I did a simple benchmark where I cloned a
Router
with 1000 routes and this brought the time down from 176.916µs to 92.698µs. So almost 50% 📈I also attempted to
Arc
the other fields but since they're!Sync
theArc
becomes!Send
which is a no-go. UsingSyncWrapper
doesn't help as that requires exclusive access which we cannot get through anArc
.