TryFrom<http::Method> for MethodFilter #1130
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
NicolaLS
force-pushed
the
try_from-http-method
branch
2 times, most recently
from
7cec360
to
c0ba0b5
Compare
davidpdrsn
reviewed
Jun 30, 2022
NicolaLS
force-pushed
the
try_from-http-method
branch
from
c0ba0b5
to
6837085
Compare
davidpdrsn
requested changes
Jun 30, 2022
davidpdrsn
reviewed
Jun 30, 2022
NicolaLS
force-pushed
the
try_from-http-method
branch
from
5ef9586
to
7356e36
Compare
NicolaLS
force-pushed
the
try_from-http-method
branch
from
7356e36
to
343c61b
Compare
davidpdrsn
approved these changes
Jul 1, 2022
Thank you for reviewing and helping so much 😁 |
davidpdrsn
added a commit
that referenced
this pull request
Jul 2, 2022
* implement TryFrom<http::Method> for MethodFilter * test for TryFrom<http::Method> for MethodFilter * 'UnsupportedMethod' error type for MethodFilter * Log TryFrom<http::Method> for MethodFilter * adjust docs * move docs Co-authored-by: David Pedersen <david.pdrsn@gmail.com>
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
I am currently switching from tide to axum in a project which also uses http-types to dynamicaly set methods. When I wanted to change that to
axum::routing::MethodFilter, I thought that it would be nice to just have aTryFrom<http::Method>for the MethodFilter, since axum already uses http and there is no unclear semantics going from e.g.http::Method::GETtoMethodFilter::GETSolution
I just added a very simple
TryFrom<Method> for MethodFilterimplementation that maps the intersecting methods from bothMethodandMethodFillterappropriately and just returns a result if there is no method inMethodFilterfor the givenhttp::Method