Return rejection if WebSocket request couldn't be upgraded
#1135
+62
−7
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jplatte
reviewed
Jul 1, 2022
davidpdrsn
commented
Jul 1, 2022
|
@jplatte I've changed the rejection to specifically call out not being able to upgrade the connection, perhaps because its http/1.0 |
|
@jplatte gentle ping (: |
|
I still don't think I'm the right person to review this though 😅 |
|
In that case I think I'll just yolo it. Its a pretty safe change and given what sean said it should be correct. |
davidpdrsn
added a commit
that referenced
this pull request
Jul 15, 2022
* Return rejection if `WebSocket` request couldn't be upgraded * make rejection about connection upgrades * changelog links
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1132
Rather than panicking we'll return a rejection. Unfortunately hyper doesn't give any details about why the connection couldn't be upgraded.