Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

expose FromRequest and FromRequestParts macros in axum #1352

Merged
merged 2 commits into from Sep 18, 2022

Conversation

tamasfe
Copy link
Contributor

@tamasfe tamasfe commented Sep 6, 2022

I would expect to just #[derive(FromRequest)] if the macros feature is enabled, this tiny PR enables that.

Copy link
Member

@davidpdrsn davidpdrsn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sure!

How does the docs look for this? Since you're exporting a proc-macro from a non-root module. Does that work?

Also, wanna add a note to the changelog as well?

@tamasfe
Copy link
Contributor Author

tamasfe commented Sep 6, 2022

The docs seem to be inlined so it's the same as in the axum-macros crate, the axum links work as well since they point to docs.rs.

screenshot

image

I've added an entry to the changelog.

@davidpdrsn davidpdrsn merged commit 84f58ae into tokio-rs:main Sep 18, 2022
@RReverser
Copy link
Contributor

FWIW the changelog seems wrong - this somehow moved from "unreleased" to "0.6.0-rc.2" section

image

but 0.6.0-rc.2 doesn't have the derives yet:

image

@davidpdrsn
Copy link
Member

@RReverser thanks for noticing. I pushed a fix in a57bd9a.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants