Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Relax Multipart FromRequest implementation bounds #1379

Merged
merged 3 commits into from Sep 16, 2022
Merged

Conversation

jplatte
Copy link
Member

@jplatte jplatte commented Sep 16, 2022

Without this, it was impossible to use tower_http::limit with Multipart because http_body::Limited doesn't implement Default.

The first commit is not a breaking change and can thus be backported to 0.5.

Copy link
Member

@davidpdrsn davidpdrsn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! Wanna add a test?

@jplatte
Copy link
Member Author

jplatte commented Sep 16, 2022

Not now, but if you want to wait I'll look into that soon-ish.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants