You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
davidpdrsn
merged 15 commits into
tokio-rs:main
from
nylonicious:body-limit-1399Sep 24, 2022
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Before I continue I wanted to ask if the implementation should live in the Bytes extractor, and if so should we also check the method like ContentLengthLimit impl used to? If the impl should live in in the Bytes extractor what with rejections, should I just extend it with the required fields or maybe add one variant to BytesRejection named something like BodyLimitRejection and store more detailed rejection inside that variant?
Before I continue I wanted to ask if the implementation should live in the Bytes extractor, and if so should we also check the method like ContentLengthLimit impl used to?
Yes I think that would be good to add as well. I think that should be its own PR though.
If the impl should live in in the Bytes extractor what with rejections, should I just extend it with the required fields or maybe add one variant to BytesRejection named something like BodyLimitRejection and store more detailed rejection inside that variant?
Hm I didn't really consider that. I suppose yes, we would have to add the rejection variants from ContentLengthLimitRejection to BytesRejection, or perhaps FailedToBufferBody.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
nylonicious
changed the title
Closes #1399
Before I continue I wanted to ask if the implementation should live in the
Bytesextractor, and if so should we also check the method likeContentLengthLimitimpl used to? If the impl should live in in the Bytes extractor what with rejections, should I just extend it with the required fields or maybe add one variant toBytesRejectionnamed something likeBodyLimitRejectionand store more detailed rejection inside that variant?