Add map_response and friends
#1414
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
davidpdrsn
commented
Sep 25, 2022
| impl<F, Fut, S, I, B, ResBody, $($ty,)*> Service<Request<B>> for MapResponse<F, S, I, ($($ty,)*)> | ||
| where | ||
| F: FnMut($($ty,)* Response<ResBody>) -> Fut + Clone + Send + 'static, | ||
| $( $ty: FromRequestParts<S> + Send, )* |
There was a problem hiding this comment.
Note that we require FromRequestParts and not FromRequest. Not sure there would be a way to recover the request afterwards so we can pass it to the inner service 🤔
If users need the request body in a map_response I think a full from_fn might be more appropriate.
There was a problem hiding this comment.
Yeah, this is exactly right IMO.
jplatte
approved these changes
Sep 25, 2022
| impl<F, Fut, S, I, B, ResBody, $($ty,)*> Service<Request<B>> for MapResponse<F, S, I, ($($ty,)*)> | ||
| where | ||
| F: FnMut($($ty,)* Response<ResBody>) -> Fut + Clone + Send + 'static, | ||
| $( $ty: FromRequestParts<S> + Send, )* |
There was a problem hiding this comment.
Yeah, this is exactly right IMO.
|
Oh, you had enabled auto-merge. Well, docs can still be improved separately :) |
🚀 😅 I'll do a follow-up |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of #1394