Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Merge handler::{WithState, IntoService} into one HandlerService type #1418

Merged
merged 2 commits into from Sep 26, 2022
Merged

Merge handler::{WithState, IntoService} into one HandlerService type #1418

merged 2 commits into from Sep 26, 2022

Conversation

jplatte
Copy link
Member

@jplatte jplatte commented Sep 25, 2022

No description provided.

@jplatte jplatte added this to the 0.6 milestone Sep 25, 2022
davidpdrsn
davidpdrsn approved these changes Sep 25, 2022
View reviewed changes
Copy link
Member

@davidpdrsn davidpdrsn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

@jplatte
Copy link
Member Author

jplatte commented Sep 26, 2022

Is there some reason you approved but didn't merge? 😄

@davidpdrsn davidpdrsn merged commit 9196c09 into main Sep 26, 2022
@davidpdrsn davidpdrsn deleted the handler-service branch September 26, 2022 12:51
@davidpdrsn
Copy link
Member

Nope :shipit:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@davidpdrsn davidpdrsn davidpdrsn approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
0.6
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@jplatte @davidpdrsn