Add #[derive(FromRef)]
#1430
Merged
Add #[derive(FromRef)]
#1430
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
probably wouldn't work at all since the whole state likely needs `Clone`
davidpdrsn
force-pushed
the
derive-from-ref
branch
from
d5d3dd2
to
37a7f2c
Compare
jplatte
reviewed
Sep 29, 2022
|
Yes I think so! Will add that later! |
jplatte
approved these changes
Oct 10, 2022
| /// [`State`]: https://docs.rs/axum/0.6/axum/extract/struct.State.html | ||
| /// [`#[derive(axum_macros::FromRef)]`]: https://docs.rs/axum-macros/latest/axum_macros/derive.FromRef.html |
There was a problem hiding this comment.
Could add axum-macros as a dev-dependency so we can use an intra-doc link here.
There was a problem hiding this comment.
Weren't there something with docsrs not building dev dependencies, and that is why we have the __private_docs feature in axum?
| /// #[derive(FromRef)] | ||
| /// struct AppState { | ||
| /// auth_token: AuthToken, | ||
| /// database_pool: DatabasePool, |
There was a problem hiding this comment.
Might be nice to have #[from_ref(skip)] so you can avoid "weird" impls like FromRef<AppState> for String.
Doesn't have to be in this PR, of course.
There was a problem hiding this comment.
Yeah I've gone back and forth on this. We can add that later if someone requests it.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Given how straight forward this is I think it makes sense to support.
TODO