Skip to content

Add RawForm extractor #1487

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 8 commits into from
Oct 20, 2022
Merged

Add RawForm extractor #1487

merged 8 commits into from
Oct 20, 2022
+139 −2

Conversation

nylonicious
Copy link
Contributor

@nylonicious nylonicious commented Oct 19, 2022 •
edited
Loading

Closes #1483

davidpdrsn
davidpdrsn reviewed Oct 20, 2022
View reviewed changes
@jplatte
Copy link
Member

jplatte commented Oct 20, 2022

Should we implement Form in terms of RawForm maybe (@davidpdrsn)?

@davidpdrsn
Copy link
Member

Should we implement Form in terms of RawForm maybe (@davidpdrsn)?

Yes thats a good idea! I don't necessarily think it needs to happen in this PR though.

@nylonicious
Copy link
Contributor Author

CI failure seems unrelated.

@jplatte
Copy link
Member

jplatte commented Oct 20, 2022

Yeah, CI failure is unrelated, fix in #1488.

davidpdrsn
davidpdrsn reviewed Oct 20, 2022
View reviewed changes
Copy link
Member

@davidpdrsn davidpdrsn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it looks good. Thanks!

Wanna add it to the changelog as well?

davidpdrsn
davidpdrsn approved these changes Oct 20, 2022
View reviewed changes
Copy link
Member

@davidpdrsn davidpdrsn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@davidpdrsn davidpdrsn enabled auto-merge (squash) October 20, 2022 17:53
@davidpdrsn davidpdrsn merged commit bc8a507 into tokio-rs:main Oct 20, 2022
@nylonicious nylonicious deleted the raw-form branch October 27, 2022 04:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@davidpdrsn davidpdrsn

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add a RawForm extractor
3 participants
@nylonicious @jplatte @davidpdrsn