Fix trailing redirection with query parameters #936
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When the request URI matches a route that need a trailing slash, or has an extra trailing slash, the redirect URI is not generated correctly. This change adds or removes a trailing slash to the path part of the URI, instead of the full URI, preserving query parameters during redirection. Signed-off-by: David Calavera <david.calavera@gmail.com>
jplatte
reviewed
Apr 16, 2022
|
There are also methods to take apart the path and query. Can't quite put it back together as easily but I think that's safer to use. We do that already in |
Extract parts from Uri and recreate it, so it doesn't bump into corner cases with string manipulation. Signed-off-by: David Calavera <david.calavera@gmail.com>
|
@jplatte, @davidpdrsn I've updated it to make it safer |
Signed-off-by: David Calavera <david.calavera@gmail.com>
davidpdrsn
requested changes
Apr 17, 2022
Co-authored-by: David Pedersen <david.pdrsn@gmail.com>
Updated |
davidpdrsn
approved these changes
Apr 17, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
When the request URI matches a route that needs a trailing slash, or has an extra trailing slash, the redirect URI is not generated correctly.
This change adds or removes a trailing slash to the path part of the URI, instead of the full URI, preserving query parameters during redirection.