Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add FromExtractor and deprecate extractor_middleware #957

Merged
merged 8 commits into from Apr 24, 2022

Conversation

arniu
Copy link
Contributor

@arniu arniu commented Apr 22, 2022

Resolve #954

Copy link
Member

@jplatte jplatte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for working in this!

You seem to have run some formatting on the changelog, please undo those (unrelated) changes.

Also, in addition to the function, the layer and response future type are also part of the public API and need to stay accessible under their old paths / names (as re-exports) to maintain backwards compatibility.

@jplatte jplatte requested a review from davidpdrsn April 23, 2022 08:19
Copy link
Member

@davidpdrsn davidpdrsn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

Wanna add an #[allow(deprecated)] to axum/src/extract/mod.rs to fix the warnings shown in GitHub?

axum/src/extract/extractor_middleware.rs Outdated Show resolved Hide resolved
@davidpdrsn davidpdrsn enabled auto-merge (squash) April 24, 2022 15:26
@davidpdrsn davidpdrsn merged commit ebecac5 into tokio-rs:main Apr 24, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Move axum::extract::extractor_middleware to axum::middleware::from_extractor
3 participants