Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

console-subscriber build error vs tokio v1.21.0 #373

Closed
redshiftzero opened this issue Sep 2, 2022 · 2 comments · Fixed by #374
Closed

console-subscriber build error vs tokio v1.21.0 #373

redshiftzero opened this issue Sep 2, 2022 · 2 comments · Fixed by #374
Labels
S-bug Severity: bug

Comments

@redshiftzero
Copy link

What crate(s) in this repo are involved in the problem?

console-subscriber

What is the issue?

One of the changes to make task::Builder::spawn* methods fallible in tokio 1.21.0 I think is causing a build error in console-subscriber

How can the bug be reproduced?

In this repo I just did cargo update and cargo build

Logs, error output, etc

   Compiling console-subscriber v0.1.7 (/Users/redshiftzero/Documents/console/console-subscriber)
error[E0308]: mismatched types
    --> console-subscriber/src/lib.rs:1066:12
     |
1061 | ) -> tokio::task::JoinHandle<T>
     |      -------------------------- expected `tokio::task::JoinHandle<T>` because of return type
...
1066 |     return tokio::task::Builder::new().name(_name).spawn(task);
     |            ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ expected struct `tokio::task::JoinHandle`, found enum `Result`
     |
     = note: expected struct `tokio::task::JoinHandle<_>`
                  found enum `Result<tokio::task::JoinHandle<_>, std::io::Error>`

For more information about this error, try `rustc --explain E0308`.
error: could not compile `console-subscriber` due to previous error
warning: build failed, waiting for other jobs to finish...

Versions

tokio 1.21.0

Possible solution

No response

Additional context

No response

Would you like to work on fixing this bug?

maybe

@mariuszmalek
Copy link

I have same problem

@Noah-Kennedy
Copy link
Contributor

This should be an easy fix.

@hawkw hawkw closed this as completed in #374 Sep 4, 2022
redshiftzero added a commit to penumbra-zone/penumbra that referenced this issue Sep 6, 2022
Due to fixing tokio-rs/console#373 upstream,
we need to use tokio 1.21.0 for console-subscriber to build
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-bug Severity: bug
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants