-
-
Notifications
You must be signed in to change notification settings - Fork 133
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update README.md #510
Update README.md #510
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
fixed : ) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for helping to improve the documentation!
I suggested some edits to the note on UTF-8 support, let me know what you think?
Also, would you mind adding a similar note to the tokio-console
crate's README, in the "running the console" section? That documentation is rendered on https://crates.io/crates/tokio-console and https://docs.rs/tokio-console, so it would be nice to include the Windows support information there as well.
Applied suggestions : ) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me. Thanks! 👍
Added note about windows
Co-authored-by: Eliza Weisman <eliza@elizas.website>
Signed-off-by: hi-rustin <rustin.liu@gmail.com>
Added note about windows