-
-
Notifications
You must be signed in to change notification settings - Fork 133
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(deps): bump tonic to 0.11 and raise MSRV to 1.70 #547
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
By bumping to a semver incompatible version of tonic
, this change needs to be marked as incompatible in the commit message (https://www.conventionalcommits.org/en/v1.0.0/).
Also, the console-api
protobuf files need to be updated, as do the ones console-subscriber
grpc web example.
For console-api
the following command needs to be run:
cargo run -p xtask -- gen-proto
For the example, the instructions are here:
https://github.com/tokio-rs/console/tree/main/console-subscriber/examples/grpc_web#understanding-the-code
BREAKING CHANGE: This is a breaking change for users of `console-api` and `console-subscriber`, as it changes the public `tonic` dependency to a semver-incompatible version. This breaks compatibility with `tonic` 0.10.x.
Hello, I came across this PR because |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me. Thanks! 👍
Blocked by #515
@hds Could you please help approve this PR? Then we can merge it. Thanks! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for adding this one!
No description provided.