unsafe impl Send+Sync for Submitter, SubmissionQueue, CompletionQueue
#283
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…onQueue` The `IoUring` type already has `Send` + `Sync` impls. In [tokio-epoll-uring](https://github.com/neondatabase/tokio-epoll-uring), we use `split()` and need the `Submitter`, `SubmissionQueue` and `CompletionQueue` to be `Send` (not sync, though). This PR adds those `unsafe impl`s, and adds hopefully not too repetitive commentary on why these impls are safe. --------- Co-authored-by: Conrad Ludgate <conrad@neon.tech> Cherry picked from commit neondatabase/fork--tokio-rs--io-uring#bbc5a0c5f6cde9051037ec2fcc648cbadb7a80b4
|
You seem to have to use unsafe to get |
|
Sorry, I'm not following. Who's talking about
The unsafe impls proposed in this PR allow movement of Submitter, SubmissionQueue, and CompletionQueue, to different threads in consuming code, without any unsafe. I consider that strictly better than the |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
IoUringtype already hasSend+Syncimpls.In tokio-epoll-uring, we use
split()and need theSubmitter,SubmissionQueueandCompletionQueueto beSend(not sync, though).This PR adds those
unsafe impls, and adds hopefully not too repetitive commentary on why these impls are safe.Co-authored-by: Conrad Ludgate conrad@neon.tech
Cherry picked from commit neondatabase@bbc5a0c