Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

prost-build: CodeGenerator::boxed method #1019

Merged
merged 4 commits into from
May 5, 2024

Commits on May 2, 2024

  1. prost-build: CodeGenerator::boxed method

    A helper method to capture the logic of deciding whether a field
    needs to be boxed. This follows the pattern with other methods like
    `optional`, and will allow reusing the logic in the upcoming builder
    codegen.
    mzabaluev committed May 2, 2024
    Configuration menu
    Copy the full SHA
    5b4e32c View commit details
    Browse the repository at this point in the history
  2. prost-build: more reuse with CodeGenerator::boxed

    The bit in CodeGenerator::append_oneof was pretty much the same,
    except the configuration is looked up for the oneof name.
    
    Rearrange the logic so that intermediate values are bound when needed.
    If a repeated fields is configured to be boxed, a deprecation warning
    will be emitted by the build script.
    mzabaluev committed May 2, 2024
    Configuration menu
    Copy the full SHA
    b3d6a61 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    3fa4069 View commit details
    Browse the repository at this point in the history

Commits on May 4, 2024

  1. prost-build: only emit warning on repeated fields

    Co-authored-by: Casper Meijn <casper@meijn.net>
    mzabaluev and caspermeijn committed May 4, 2024
    Configuration menu
    Copy the full SHA
    626bb3f View commit details
    Browse the repository at this point in the history