workspace package metadata #1036
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gibbz00
force-pushed
the
workspace_package
branch
from
eab9457
to
b11461a
Compare
caspermeijn
requested changes
Apr 22, 2024
| @@ -6,7 +6,7 @@ license.workspace = true | |||
| repository.workspace = true | |||
| readme = "README.md" | |||
| description.workspace = true | |||
| edition = "2021" | |||
There was a problem hiding this comment.
I think we should only centralize values that are the same for all crates. It can be confusing when the edition is set at the workspace level, but different for other crates.
So we should update the edition of the other crates before doing this commit.
There was a problem hiding this comment.
Now that the private projects have the same edition, then can also use the workspace.edition.
gibbz00
force-pushed
the
workspace_package
branch
from
b11461a
to
50871f3
Compare
gibbz00
force-pushed
the
workspace_package
branch
from
50871f3
to
a234ba4
Compare
gibbz00
force-pushed
the
workspace_package
branch
from
a234ba4
to
2b8f3a3
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Depends on #1033(merged into master and rebased here)