Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update bytes to 0.6 #387

Merged
merged 1 commit into from
Nov 9, 2020
Merged

Update bytes to 0.6 #387

merged 1 commit into from
Nov 9, 2020

Conversation

danburkert
Copy link
Collaborator

This change updates the bytes crate dependencies to version 0.6.

Fixes https://github.com/danburkert/prost/issues/380

@olix0r @danburkert
Update bytes to 0.6
cc7ffa3 
This change updates the `bytes` crate dependencies to version 0.6.

Fixes https://github.com/danburkert/prost/issues/380
@danburkert
Copy link
Collaborator Author

danburkert commented Nov 9, 2020 •
edited

This is #381 but with encode_varint switched back to the faster unsafe version. When pointing to a bytes version which include tokio-rs/bytes#442 and tokio-rs/bytes#443 benchmarks are the same or slightly better than bytes 0.5.

@danburkert danburkert mentioned this pull request Nov 9, 2020
Closed
@danburkert danburkert merged commit ca6de9f into master Nov 9, 2020
@danburkert danburkert deleted the ver/bytes-0.6 branch November 9, 2020 21:58
@danburkert danburkert mentioned this pull request Nov 15, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

upgrade to bytes 0.6
2 participants
@danburkert @olix0r