feat: impl Name for some well-known types #933
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The CI failed due to compiler version requirement mismatch: error: package Anyone who knows how to fix the CI failure? Thanks! |
caspermeijn
reviewed
Feb 28, 2024
There was a problem hiding this comment.
Please rebase to latest master to fix CI.
I would like to see some tests. You could add something like this to tests/src/type_names.rs:
assert_eq!("BoolValue", bool::NAME);
assert_eq!("google.protobuf", bool::PACKAGE);
assert_eq!("google.protobuf.BoolValue", bool::full_name());
assert_eq!("type.googleapis.com/google.protobuf.BoolValue", bool::type_url());|
|
||
| /// Compute the type URL for the given `google.protobuf` type, using `type.googleapis.com` as the | ||
| /// authority for the URL. | ||
| fn type_url_for<T: Name>() -> String { |
There was a problem hiding this comment.
This function is specific to googleapis url. I would reflect that in the function name.
Suggested change
| fn type_url_for<T: Name>() -> String { | |
| fn googleapis_type_url_for<T: Name>() -> String { |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implement the newly added
Nametrait for well-known wrapper types, e.g.google.protobuf.Empty.