feat: encode string and bytes slices #979
Conversation
guilload
force-pushed
the
guilload/encode-str-and-bytes-slices
branch
2 times, most recently
from
09db470
to
ce9de1c
Compare
|
Can you provide some motivation for this change |
|
@morrisonlevi provided some context in his original PR: #978. My use case is similar. I recently wrote a few custom |
guilload
force-pushed
the
guilload/encode-str-and-bytes-slices
branch
from
ce9de1c
to
d61c094
Compare
|
@caspermeijn, is there any chance you can look into this PR? |
|
|
||
| pub trait BytesAdapter: Default + Sized + 'static { | ||
| pub trait BytesAdapter: Default + Sized + AsRef<[u8]> + 'static { |
There was a problem hiding this comment.
BytesAdapter is not used anymore for encode, but it seems to still be used for encoded_len. Will this mismatch cause issues for other people?
| @@ -794,13 +794,15 @@ macro_rules! length_delimited { | |||
| pub mod string { | |||
| use super::*; | |||
|
|
|||
| pub fn encode<B>(tag: u32, value: &String, buf: &mut B) | |||
| pub fn encode<S, B>(tag: u32, value: &S, buf: &mut B) | |||
There was a problem hiding this comment.
I would like to see tests to guarantee String can still be used on this function.
And you need to add tests for your new use case, to make sure it is not broken in the future.
| } | ||
|
|
||
| pub mod bytes { | ||
| use super::*; | ||
|
|
||
| pub fn encode<A, B>(tag: u32, value: &A, buf: &mut B) | ||
| where | ||
| A: BytesAdapter, | ||
| A: AsRef<[u8]>, |
There was a problem hiding this comment.
I would like to see tests to guarantee impl BytesAdapter, Bytes and Vec<u8> can still be used on this function.
And you need to add tests for your new use case, to make sure it is not broken in the future.
No description provided.