chore: Relax MSRV #983
Open
chore: Relax MSRV #983
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tottoto
force-pushed
the
relax-msrv
branch
3 times, most recently
from
0fc1dc4
to
c3b1610
Compare
caspermeijn
reviewed
Feb 29, 2024
There was a problem hiding this comment.
I prefer to keep the whole repo at the same MSRV. With the removal of which in #962 the MSRV of the published crates can be lowered to rust 1.65. Would that be enough for your use case?
I suggest to only do a CI build with stable toolchain (so remove the 1.70 toolchain) and to add your proposed MSRV check.
|
Since checking MSRV for different crates can be performed easily as this pull request describes, and the crates except for |
tottoto
force-pushed
the
relax-msrv
branch
2 times, most recently
from
8a78c81
to
7e4f10b
Compare
caspermeijn
requested changes
Apr 21, 2024
|
I opened a new PR with only the CI improvement: #1057 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Relaxes MSRV which are bumped in #982. As the use of
prost-buildcan be separated to the different build process, it is too strict to set the same MSRV ofprost-buildto the other crates for users.cargo-hack's--rust-versionoption can be used to perform checking different MSRVs on the project crates.