Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update README.md to improve wording #210

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Conversation

yerke
Copy link

@yerke yerke commented Jan 12, 2023

No description provided.

@FrankReh
Copy link
Collaborator

@Noah-Kennedy I think we know by now that if the README is going to recommend a kernel, it should either say uring kernel feature development and bug fixing has gone well into the 6.1 kernel or it should say the user of this crate should check with the uring status of the kernel they are trying to target. Calling out any old kernel version explicitly sounds like the crate author is making a recommendation on what minimal kernel will work.

@Noah-Kennedy
Copy link
Contributor

@FrankReh I'm in complete agreement here

@yerke
Copy link
Author

yerke commented Jan 16, 2023

Do you want me to update the wording in this PR somehow? Or should I just close it and let me you handle it separately? Thanks.

@FrankReh
Copy link
Collaborator

I suggest you leave this open and we can treat it as an open Issue. I think Noah will change the README at some point and this can then be closed. Thanks for wanting to help. At this point, it's better to leave an old comment as it should be pretty evident it is an old/obsolete recommendation.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants