Refresh: Update Result<T, B> to be Result<(T,B), Error<B>

[ollie-etl]

This PR is a update of #267, which seems to have gone stale, due to inactivity on in this repo.

Changes the return type to be a Result of tuples, instead of a tuple containing a result and a buffer. This allows this crate to work in a more ergenomic fashion with ? operator

In addition to updating the original PR, the following changes are made in this one, not in the original

• BufError renamed Error. This follows the more usual convention of using crate prefixes to qualify error types, rather than the type name itself.
• BufResult renamed Result. This is the same rational
• map_buf helper function implrmented with a sealed trait, to give method calling convention, rather than qualified calls

closes #178

[ollie-etl]

@ileixe would you care to review?
@Noah-Kennedy / @carllerche / other maintainer? Any opinions?

[ileixe]

Thanks for pushing this forward. We're waiting for a while this :)

I usually prefer qualifying Error and Result, but on the other hand I thought Buf prefix worth its own as it's a bit different from plain Result. (We're using BufResult and Result in the same place). Let me leave it to someone else.

[ollie-etl]

@ileixe Does this address your comment?

[ileixe]

@ollie-etl Exactly, thanks! Ah I did not aware it's not callable outside crate. Can you provide such traits callable (via sealed supertrait)? I think it's common to call it from compatibility layer (to abstract read via uring / non-uring). We ourselves are using it outside the crate.

[ollie-etl]

@ileixe That makes sense - done