Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

net: add documentation to try_read() for zero-length buffers #4937

Merged
merged 12 commits into from Aug 25, 2022
Merged

net: add documentation to try_read() for zero-length buffers #4937

merged 12 commits into from Aug 25, 2022

Commits on Aug 24, 2022

  1. net: add documentation for try_read() 

    The previous documentation falsely implied that a return  value of `Ok(0)`
from `try_read()` always meant that the stream's read half had closed.

However, `Ok(0)` can be returned while the stream's read half is
still open if the specified buffer has a length of 0.
    @isikkema
    isikkema committed Aug 24, 2022
    Copy the full SHA
    09f02c4 View commit details
    Browse the repository at this point in the history

  2. net: add missing comma to try_read() docs

    @isikkema
    isikkema committed Aug 24, 2022
    Copy the full SHA
    32ce71d View commit details
    Browse the repository at this point in the history

  3. net: rustfmt

    @isikkema
    isikkema committed Aug 24, 2022
    Copy the full SHA
    e2a827a View commit details
    Browse the repository at this point in the history

  4. net: commit suggested language change 

    Co-authored-by: Alice Ryhl <aliceryhl@google.com>
    @isikkema @Darksonn
    isikkema and Darksonn committed Aug 24, 2022
    Copy the full SHA
    a0591bf View commit details
    Browse the repository at this point in the history

  5. net: update try_read() doc in split_owned.rs

    Sikkema, Isaac committed Aug 24, 2022
    Copy the full SHA
    00c3620 View commit details
    Browse the repository at this point in the history

  6. net: update try_read() doc in split.rs

    Sikkema, Isaac committed Aug 24, 2022
    Copy the full SHA
    3b91039 View commit details
    Browse the repository at this point in the history

  7. net: fix try_read() doc in unix/split_owned.rs

    Sikkema, Isaac committed Aug 24, 2022
    Copy the full SHA
    d29a133 View commit details
    Browse the repository at this point in the history

  8. net: fix try_read() doc in unix/split.rs

    Sikkema, Isaac committed Aug 24, 2022
    Copy the full SHA
    2063aba View commit details
    Browse the repository at this point in the history

  9. net: fix try_read() doc in unix/stream.rs

    Sikkema, Isaac committed Aug 24, 2022
    Copy the full SHA
    f6fc38f View commit details
    Browse the repository at this point in the history

  10. net: fix try_read() doc in NamedPipeServer

    Sikkema, Isaac committed Aug 24, 2022
    Copy the full SHA
    870f767 View commit details
    Browse the repository at this point in the history

  11. net: fix try_read() doc in NamedPipeClient

    Sikkema, Isaac committed Aug 24, 2022
    Copy the full SHA
    be13b47 View commit details
    Browse the repository at this point in the history

  12. Merge branch 'master' into isikkema/zero-size-buf-try-read-doc

    @isikkema
    isikkema committed Aug 24, 2022
    Copy the full SHA
    d133d57 View commit details
    Browse the repository at this point in the history