Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: vendor once_cell #5043

Closed
wants to merge 7 commits into from
Closed

chore: vendor once_cell #5043

wants to merge 7 commits into from

Conversation

Noah-Kennedy
Copy link
Contributor

Fixes #3212.

With the release of v1.15, the once_cell crate is breaking our current MSRV. Vendoring it will allow us to keep using certain APIs from that crate without compromising our MSRV.

Fixes #3212.

With the release of `v1.15`, the once_cell crate is breaking our current MSRV. Vendoring it will allow us to keep using certain APIs from that crate without compromising our MSRV.
@github-actions github-actions bot added the R-loom Run loom tests on this PR label Sep 21, 2022
@Noah-Kennedy Noah-Kennedy marked this pull request as ready for review September 21, 2022 22:47
@Noah-Kennedy
Copy link
Contributor Author

Declining in favor of just moving off of once_cell without vendoring

@Noah-Kennedy Noah-Kennedy deleted the noah/vendor-once-cell branch September 30, 2022 03:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
R-loom Run loom tests on this PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Should we vendor once_cell?
1 participant