Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

time: Do not overflow to signal value #5710

Merged
merged 3 commits into from Jun 10, 2023
Merged

time: Do not overflow to signal value #5710

merged 3 commits into from Jun 10, 2023

Commits on May 23, 2023

  1. rt: Resolve panic with large duration sleeps 

    Durations far into the future would cause the conversion of millis
from u128 to u64 to fail and set the value to u64::MAX. This in turn
causes issues since u64::MAX is used as a signal value.

This patch adds a new constant that is the largest non-signal value
that can be used for ticks. And uses that in the location it causes
issues.
    @Erk-
    Erk- committed May 23, 2023
    Configuration menu
    Copy the full SHA
    48cdd43 View commit details
    Browse the repository at this point in the history

Commits on Jun 10, 2023

  1. bias the select! to ensure that the long sleep is awaited first.

    @Erk-
    Erk- committed Jun 10, 2023
    Configuration menu
    Copy the full SHA
    0015c26 View commit details
    Browse the repository at this point in the history

  2. skip rustfmt to align biased;

    @Erk-
    Erk- committed Jun 10, 2023
    Configuration menu
    Copy the full SHA
    42605d3 View commit details
    Browse the repository at this point in the history