Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

runtime: expand on sharing runtime docs #5858

Merged
merged 1 commit into from Jul 10, 2023
Merged

runtime: expand on sharing runtime docs #5858

merged 1 commit into from Jul 10, 2023

Conversation

Darksonn
Copy link
Contributor

@Darksonn Darksonn commented Jul 10, 2023 •
edited

I saw someone discuss this section in the Tokio Discord, and thought that it could use some improvement.

@Darksonn Darksonn added T-docs Topic: documentation A-tokio Area: The main tokio crate M-runtime Module: tokio/runtime labels Jul 10, 2023
@github-actions github-actions bot added the R-loom Run loom tests on this PR label Jul 10, 2023
hds
hds approved these changes Jul 10, 2023
View reviewed changes
Copy link
Contributor

@hds hds left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this looks good. At first I didn't quite get how enter() counted as sharing. But I couldn't think of a clearer way of describing it than what you've already got.

@Darksonn Darksonn merged commit 91ad76c into master Jul 10, 2023
74 checks passed
@Darksonn Darksonn deleted the alice/runtime-sharing-doc branch July 10, 2023 14:24
@Darksonn Darksonn mentioned this pull request Aug 9, 2023
Merged
@D3PSI D3PSI mentioned this pull request Aug 9, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hds hds hds approved these changes

Assignees
No one assigned
Labels
A-tokio Area: The main tokio crate M-runtime Module: tokio/runtime R-loom Run loom tests on this PR T-docs Topic: documentation
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@Darksonn @hds