Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add task counter pairs #6114
base: master
Are you sure you want to change the base?
feat: add task counter pairs #6114
Changes from all commits
63d85dd
3d5f34e
0833885
8568aac
9a00ce7
d5c01f0
e14ae50
6f9cece
34834e7
28f0562
6497d0c
a7713db
77df06c
d0d64cf
d82e448
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's not because the counter uses relaxed orderings. Rather, it's because we call
wake_join()
beforeself.release()
here:tokio/tokio/src/runtime/task/harness.rs
Lines 324 to 333 in 6fcd9c0
The decrement happens somewhere inside
self.release()
.I'm happy to merge this without the assert, but please fix the comment.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One thing we could do is to use a sleep-loop until the two values are equal. This way we assert that it goes back to zero eventually. You can fail the test if it's still non-zero after 10 seconds.