New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
time: lazy init TimerShared in TimerEntry #6512
Merged
Darksonn
merged 25 commits into
tokio-rs:master
from
wathenjiang:timeout-lazy-init-sleep
May 3, 2024
Merged
time: lazy init TimerShared in TimerEntry #6512
Darksonn
merged 25 commits into
tokio-rs:master
from
wathenjiang:timeout-lazy-init-sleep
May 3, 2024
Commits on Apr 23, 2024
-
This commit is part of reducing timeout performance overhead.
See tokio-rs#6504 Below are relevant benchmark results of this PR on m1 mac: single_thread_timeout time: [21.869 ns 21.987 ns 22.135 ns] change: [-3.4429% -2.0709% -0.8759%] (p = 0.00 < 0.05) Change within noise threshold. Found 7 outliers among 100 measurements (7.00%) 3 (3.00%) high mild 4 (4.00%) high severe multi_thread_timeout-8 time: [4.4835 ns 4.6138 ns 4.7614 ns] change: [-4.3554% +0.1643% +4.5114%] (p = 0.95 > 0.05) No change in performance detected. Found 9 outliers among 100 measurements (9.00%) 8 (8.00%) high mild 1 (1.00%) high severe Below are relevant benchmark results of current version on m1 mac: single_thread_timeout time: [40.227 ns 40.416 ns 40.691 ns] change: [+81.321% +82.817% +84.121%] (p = 0.00 < 0.05) Performance has regressed. Found 14 outliers among 100 measurements (14.00%) 3 (3.00%) high mild 11 (11.00%) high severe multi_thread_timeout-8 time: [183.16 ns 186.02 ns 188.21 ns] change: [+3765.0% +3880.4% +3987.4%] (p = 0.00 < 0.05) Performance has regressed. Found 10 outliers among 100 measurements (10.00%) 4 (4.00%) low severe 6 (6.00%) low mild
Configuration menu - View commit details
-
Copy full SHA for bde0742 - Browse repository at this point
Copy the full SHA bde0742View commit details -
Configuration menu - View commit details
-
Copy full SHA for 0eb1d3e - Browse repository at this point
Copy the full SHA 0eb1d3eView commit details -
Configuration menu - View commit details
-
Copy full SHA for a4e1231 - Browse repository at this point
Copy the full SHA a4e1231View commit details
Commits on Apr 24, 2024
-
Configuration menu - View commit details
-
Copy full SHA for cb54a1e - Browse repository at this point
Copy the full SHA cb54a1eView commit details -
Configuration menu - View commit details
-
Copy full SHA for f8874b2 - Browse repository at this point
Copy the full SHA f8874b2View commit details -
Configuration menu - View commit details
-
Copy full SHA for 9dd1e33 - Browse repository at this point
Copy the full SHA 9dd1e33View commit details -
Configuration menu - View commit details
-
Copy full SHA for 2d3efb6 - Browse repository at this point
Copy the full SHA 2d3efb6View commit details -
Configuration menu - View commit details
-
Copy full SHA for 1ae3de2 - Browse repository at this point
Copy the full SHA 1ae3de2View commit details -
Configuration menu - View commit details
-
Copy full SHA for ef3630b - Browse repository at this point
Copy the full SHA ef3630bView commit details -
Configuration menu - View commit details
-
Copy full SHA for d4a95a3 - Browse repository at this point
Copy the full SHA d4a95a3View commit details -
Configuration menu - View commit details
-
Copy full SHA for f6fa09b - Browse repository at this point
Copy the full SHA f6fa09bView commit details -
Configuration menu - View commit details
-
Copy full SHA for b1fa990 - Browse repository at this point
Copy the full SHA b1fa990View commit details -
Configuration menu - View commit details
-
Copy full SHA for 8c0c2e8 - Browse repository at this point
Copy the full SHA 8c0c2e8View commit details -
Configuration menu - View commit details
-
Copy full SHA for a9a11e9 - Browse repository at this point
Copy the full SHA a9a11e9View commit details -
Configuration menu - View commit details
-
Copy full SHA for ef657d2 - Browse repository at this point
Copy the full SHA ef657d2View commit details -
Configuration menu - View commit details
-
Copy full SHA for a446e44 - Browse repository at this point
Copy the full SHA a446e44View commit details
Commits on Apr 25, 2024
-
Configuration menu - View commit details
-
Copy full SHA for 3a89c45 - Browse repository at this point
Copy the full SHA 3a89c45View commit details -
Configuration menu - View commit details
-
Copy full SHA for c47b739 - Browse repository at this point
Copy the full SHA c47b739View commit details -
Configuration menu - View commit details
-
Copy full SHA for 8e40ec4 - Browse repository at this point
Copy the full SHA 8e40ec4View commit details
Commits on Apr 26, 2024
-
Configuration menu - View commit details
-
Copy full SHA for d328298 - Browse repository at this point
Copy the full SHA d328298View commit details
Commits on May 2, 2024
-
Configuration menu - View commit details
-
Copy full SHA for 07953b5 - Browse repository at this point
Copy the full SHA 07953b5View commit details -
Configuration menu - View commit details
-
Copy full SHA for 373044d - Browse repository at this point
Copy the full SHA 373044dView commit details -
Configuration menu - View commit details
-
Copy full SHA for 0129c92 - Browse repository at this point
Copy the full SHA 0129c92View commit details -
Configuration menu - View commit details
-
Copy full SHA for b492723 - Browse repository at this point
Copy the full SHA b492723View commit details
Commits on May 3, 2024
-
Configuration menu - View commit details
-
Copy full SHA for 8af2a97 - Browse repository at this point
Copy the full SHA 8af2a97View commit details
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.