Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

attributes: fix handling of inner attributes #2307

Merged
merged 6 commits into from Oct 6, 2022
Merged

attributes: fix handling of inner attributes #2307

merged 6 commits into from Oct 6, 2022

Commits on Sep 16, 2022

  1. attributes: fix handling of inner attributes 

    I updated the code to parse out the inner attributes fron the
function body first and that wasn't too bad. I couldn't keep the
`From<&'a ItemFn>` impl for `MaybeItemFnRef` due to lifetime
issues though, so now it's `impl TryFrom<ItemFn> for MaybeItemFn`.

Fixes: tokio-rs#2294
    @e-nomem
    e-nomem committed Sep 16, 2022
    Copy the full SHA
    39f8fe9 View commit details
    Browse the repository at this point in the history

Commits on Sep 17, 2022

  1. Fix warning

    @e-nomem
    e-nomem committed Sep 17, 2022
    Copy the full SHA
    e56c621 View commit details
    Browse the repository at this point in the history

  2. Merge remote-tracking branch 'upstream/master' into handle-inner-attrs

    @e-nomem
    e-nomem committed Sep 17, 2022
    Copy the full SHA
    488b15e View commit details
    Browse the repository at this point in the history

Commits on Oct 6, 2022

  1. Merge branch 'master' into handle-inner-attrs

    @hawkw
    hawkw committed Oct 6, 2022
    Copy the full SHA
    3dbb7d6 View commit details
    Browse the repository at this point in the history

  2. don't re-parse ItemFn in MaybeItemFn conversion

    @hawkw
    hawkw committed Oct 6, 2022
    Copy the full SHA
    a113fde View commit details
    Browse the repository at this point in the history

  3. fail tests if inner attrs are eaten

    @hawkw
    hawkw committed Oct 6, 2022
    Copy the full SHA
    5a27105 View commit details
    Browse the repository at this point in the history