Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update to syn-2 #2544

Closed
wants to merge 1 commit into from
Closed

Update to syn-2 #2544

wants to merge 1 commit into from

Conversation

maurer
Copy link

@maurer maurer commented Apr 4, 2023

Motivation

Migration to syn-2 helps avoid multiple versions of syn going into the same project. The main tokio repo has already moved.

Solution

Aside from syn API updates, the two primary changes are:

  1. self no longer parses as an Ident, so a compatibility shim to allow it to appear in skip was required.
  2. MSRV is bumped to 1.56 for tracing-attributes due to the syn crate's MSRV.

Requires a MSRV bump to 1.56 for tracing-attributes due to the syn-2
MSRV.
@maurer maurer requested review from hawkw, davidbarsky and a team as code owners April 4, 2023 22:02
@davidbarsky
Copy link
Member

I think we'll get moved over to syn 2.0 once tracing-opentelemetry has been fully moved over to the new repo.

@hawkw
Copy link
Member

hawkw commented Apr 4, 2023

See also the existing PR #2516 (which is blocked on getting CI un-broken, as David mentioned...)

@davidbarsky
Copy link
Member

Oh, yeah—I think David got to the syn update first. I'll close this PR in favor of that one. Thanks for you help, though!

@davidbarsky davidbarsky closed this Apr 4, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants