-
Notifications
You must be signed in to change notification settings - Fork 663
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fmt::Subscriber NO_COLOR
support
#2647
Merged
Merged
Commits on Jul 13, 2023
-
fmt::Subscriber
NO_COLOR
supportThe `NO_COLOR` environment variable should disable all ANSI color output (https:://no-color.org). This commit updates `fmt::Subscriber` to check the `NO_COLOR` environment variable before enabling ANSI color output. As described in the spec, any non-empty value set for `NO_COLOR` will prevent `is_ansi` from being set to `true`. fixes tokio-rs#2388
Configuration menu - View commit details
-
Copy full SHA for 8fa10c9 - Browse repository at this point
Copy the full SHA 8fa10c9View commit details -
update to allow
NO_COLOR
to be overriddenRe-reading https://no-color.org showed that they do allow overriding of the setting with command-line flags. Similarly, I've removed the changes to `fmt::subscriber::with_ansi` and `fmt::subscriber::set_ansi`; they will once again set `is_ansi` regardless of `NO_COLOR`.
Configuration menu - View commit details
-
Copy full SHA for f9f3f8c - Browse repository at this point
Copy the full SHA f9f3f8cView commit details
Commits on Aug 15, 2023
-
use a Drop guard in NO_COLOR tests
Co-authored-by: Eliza Weisman <eliza@buoyant.io>
Configuration menu - View commit details
-
Copy full SHA for 9bb797c - Browse repository at this point
Copy the full SHA 9bb797cView commit details -
Configuration menu - View commit details
-
Copy full SHA for e56544a - Browse repository at this point
Copy the full SHA e56544aView commit details
Commits on Aug 16, 2023
-
Configuration menu - View commit details
-
Copy full SHA for 133f17d - Browse repository at this point
Copy the full SHA 133f17dView commit details -
Configuration menu - View commit details
-
Copy full SHA for b5c40b7 - Browse repository at this point
Copy the full SHA b5c40b7View commit details -
Merge remote-tracking branch 'refs/remotes/origin/subscriber-no_color…
…' into subscriber-no_color
Configuration menu - View commit details
-
Copy full SHA for e90ad01 - Browse repository at this point
Copy the full SHA e90ad01View commit details
Commits on Aug 17, 2023
-
Configuration menu - View commit details
-
Copy full SHA for fd00fb9 - Browse repository at this point
Copy the full SHA fd00fb9View commit details -
Configuration menu - View commit details
-
Copy full SHA for 218f9c0 - Browse repository at this point
Copy the full SHA 218f9c0View commit details
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.