Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tracing: add index API for Field #2820

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

hi-rustin
Copy link

Motivation

Expose the index of the field. See more at: tokio-rs/console#462 (comment)

Solution

Just added a new API.

tracing-core/src/field.rs Show resolved Hide resolved
Copy link
Author

@hi-rustin hi-rustin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🔢 Self-check

Copy link
Contributor

@hds hds left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! This looks good to me, but I'd like @hawkw to review.

@hi-rustin hi-rustin force-pushed the rustin-patch-field-index branch 2 times, most recently from 0ff46c2 to 667dbcb Compare January 29, 2024 12:29
@hi-rustin
Copy link
Author

@hawkw Friendly ping~

Signed-off-by: hi-rustin <rustin.liu@gmail.com>
Signed-off-by: hi-rustin <rustin.liu@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants