Fixed router transitions/animations #498
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixed broken router transitions/animations
|
Hi @dyingangel666 ! Thx for the contribution! Could you please follow conventional commit message format ? And also it would be great if the PR was re based into single commit (for example using So in the end PR should be one commit which will look something like this Besides that can you please have a look on the failing build (its just a prettier error, so formating, can be fixed using Thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixed the animations for the router transitions which are broken in Safari and Edge because a inline style from the animation "position: fixed" was not properly removed.
Closes: #495
Closes: #493