Fix toSnakeCase bug when using camelCase strings #182
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The regex that was previously used to convert strings to snake_case did not account for camelCase or StartCamelCase strings, so it simply downcased the entire string and returned that. This adds a new regex that is used to handle camelCase and StartCamelCase strings, as well as the strings previously present in the test cases. This also adds a new function called `splitByNonDowncaseAlphaNumeric` that will split a string based on this new regex, trim whitespace from all strings, and then reject empty strings. Fixes tommmyy#169
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The regex that was previously used to convert strings to snake_case did
not account for camelCase or StartCamelCase strings, so it simply
downcased the entire string and returned that.
This adds a new regex that is used to handle camelCase and StartCamelCase
strings, as well as the strings previously present in the test cases.
This also adds a new function called
splitByNonDowncaseAlphaNumericthat will split a string based on this new regex, trim whitespace from
all strings, and then reject empty strings.
Fixes #169
Checklist
Be in accordance with the latest Code of Conduct and Guideslines of Contributing.