Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

修正查询缓存 #527

Open
wants to merge 3 commits into
base: 3.0
Choose a base branch
from
Open

修正查询缓存 #527

wants to merge 3 commits into from

Conversation

Hhh0121
Copy link
Contributor

@Hhh0121 Hhh0121 commented Mar 28, 2024

image
image
1:查询不存在的数据,首次查询返回null,后续返回false
image
image
2:查询不存在的json字段,首次查询返回null,后续报错
image
修正:1:cache缓存方法,应当不缓存数据为空的情况,已在value和column查询修正;2:当cacheAlways方法允许缓存空数据的情况,value方法应当缓存默认值,而不是false,会导致json数据解析报错 #468 #342 @liu21st

@codecov-commenter
Copy link

Codecov Report

Attention: Patch coverage is 88.88889% with 2 lines in your changes are missing coverage. Please review.

Project coverage is 12.28%. Comparing base (e35f497) to head (17e6700).

Files Patch % Lines
src/db/PDOConnection.php 88.88% 2 Missing ⚠️

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@             Coverage Diff              @@
##                3.0     #527      +/-   ##
============================================
+ Coverage     12.24%   12.28%   +0.03%     
- Complexity     2965     2969       +4     
============================================
  Files            64       64              
  Lines          7129     7131       +2     
============================================
+ Hits            873      876       +3     
+ Misses         6256     6255       -1     
Flag Coverage Δ
unittests 12.28% <88.88%> (+0.03%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants