feat: add runId to slack thread when sanities fail #270
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
noahnu
reviewed
Mar 28, 2022
service/src/alertOnResult.js
Outdated
| title: 'runId for sanity test:', | ||
| text: message.runId, | ||
| }) | ||
| } |
There was a problem hiding this comment.
I think this is perfectly fine to merge as is, though something I'd like to do when my larger PR is merged in is consolidate all the slack messages into a single message for improved readability and to reduce chance of rate limiting.
There was a problem hiding this comment.
Agreed, I don't love the thread either.
Created story: https://tophat.atlassian.net/browse/SERVINFRA-1246
|
You'll want to rebase |
dingxuanyao
force-pushed
the
ty/SERVINFRA-1209
branch
3 times, most recently
from
7453d8e
to
d7db28b
Compare
noahnu
reviewed
Apr 11, 2022
service/src/alerts/index.ts
Outdated
| }: { | ||
| testFiles: Record<string, string> | ||
| results: EnhancedAggregatedResult | ||
| testVariables: Partial<Record<string, string>> | ||
| runId: string, |
There was a problem hiding this comment.
Suggested change
| runId: string, | |
| runId: string |
L20 is a typescript type which uses semicolons or newlines as separators. So you can just remove the comma
There was a problem hiding this comment.
Thanks @noahnu 🙏 , test is passing now.
dingxuanyao
force-pushed
the
ty/SERVINFRA-1209
branch
from
d7db28b
to
8b7ba05
Compare
noahnu
approved these changes
Apr 11, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://tophat.atlassian.net/jira/software/c/projects/WEB/boards/247?modal=detail&selectedIssue=SERVINFRA-1209