Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix some minor issues in recognition and loading of custom configs #72

Merged
merged 2 commits into from Mar 15, 2022
Merged

Fix some minor issues in recognition and loading of custom configs #72

merged 2 commits into from Mar 15, 2022

Conversation

TomerAberbach
Copy link
Contributor

The two issues:

  1. The logic for finding the custom config command line argument would not work for all cases. In some cases the name of the binary would be the full path to cli.js so the check for 'simple-git-hooks' wouldn't work. It's sufficient to assume the config file path will always be at index 2.
  2. The config file loader assumes that the given path is relative to the project directory, but this isn't necessarily the case for a custom config path (I could provide it as an absolute path). I fixed this by checking whether the path is already absolute.

@toplenboren
Copy link
Owner

toplenboren commented Mar 15, 2022

Thank you for this PR 🚀

Gonna include it into release ...

@toplenboren toplenboren merged commit a6f04b7 into toplenboren:master Mar 15, 2022
@TomerAberbach
Copy link
Contributor Author

@toplenboren any chance the next version could be released soon? I'm currently relying on my fork for the fix.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants