Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CI-3516] Change build-push-image action #315

Merged
merged 6 commits into from
Jun 3, 2024

Conversation

jcobarreto
Copy link
Contributor

@jcobarreto jcobarreto commented May 13, 2024

CI-3516

Description

Change the davinci-github-actions/build-push-action to be more generic and use it when switching from Jenkins build image jobs to GitHub actions.

PR commands

List of available commands:

  • @toptal-anvil ping reviewers - Ping FX team for review

@jcobarreto jcobarreto self-assigned this May 13, 2024
Copy link

changeset-bot bot commented May 13, 2024

🦋 Changeset detected

Latest commit: 9af99cc

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
davinci-github-actions Major

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@jcobarreto jcobarreto force-pushed the ci-3516-change-build-push-image-action branch 28 times, most recently from fbe4e86 to f4b7fd5 Compare May 13, 2024 18:50
@jcobarreto jcobarreto force-pushed the ci-3516-change-build-push-image-action branch 8 times, most recently from 252bb76 to ab77645 Compare May 28, 2024 18:43
@jcobarreto jcobarreto force-pushed the ci-3516-change-build-push-image-action branch from ab77645 to 065c7f7 Compare May 29, 2024 18:55
@jcobarreto
Copy link
Contributor Author

@toptal-anvil ping reviewers

@jcobarreto jcobarreto requested a review from a team May 29, 2024 19:34
@jcobarreto
Copy link
Contributor Author

@toptal-anvil ping reviewers

@Jakub-Kwak
Copy link
Contributor

Hey @jcobarreto, could you share some test run of this action after changes?

Copy link
Contributor

@Jakub-Kwak Jakub-Kwak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@jcobarreto
Copy link
Contributor Author

@toptal-anvil ping reviewers

Copy link
Collaborator

@dmaklygin dmaklygin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good job!

@jcobarreto jcobarreto merged commit fc0a39d into master Jun 3, 2024
3 checks passed
@jcobarreto jcobarreto deleted the ci-3516-change-build-push-image-action branch June 3, 2024 14:03
@github-actions github-actions bot mentioned this pull request Jun 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants