Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(deps-dev): bump puppeteer from 1.19.0 to 3.0.2 #1265

Closed

Conversation

dependabot-preview[bot]
Copy link
Contributor

@dependabot-preview dependabot-preview bot commented Apr 28, 2020

⚠️ Dependabot Preview has been deactivated ⚠️

This pull request was created by Dependabot Preview, and you've upgraded to Dependabot. This means it won't respond to dependabot commands nor will it be automatically closed if a new version is found.

If you close this pull request, Dependabot will re-create it the next time it checks for updates and everything will work as expected.


READ ME FIRST!!!

=====================================================

Bumps puppeteer from 1.19.0 to 3.0.2.

Release notes

Sourced from puppeteer's releases.

v3.0.2

Highlights

  • uploadFile now throws for non-existent files (#5733)
  • Puppeteer currently fails to extract Chromium when installing on Node 14 (see tracking bug: #5719). We now detect if you're on Node 14 and log a helpful error (#5732).

Behind the scenes

  • Many more files have been migrated to TypeScript and we're continuing with the goal of the src directory being 100% TypeScript.

Raw notes

4e8f091 - chore: mark version v3.0.2 3911836 - chore: small CI tidy ups (#5751) 5e2a029 - chore: use Node's promisify function (#5748) 1b9d9e9cc0ea8026b057e1dc28eac625d6646057 - chore: log useful error for Node v14 breakage (#5732) a7d2485 - chore: split out CI into unit tests + extra checks (#5749) 3ed2f6b - chore: remove puppeteer-web (#5750) 1358b45 - chore: migrate src/LifecycleWatcher (#5734) 79e82e5 - fix: make uploadFile throw for non-existent files (#5733) 1a4e260 - chore: migrate src/BrowserFetcher to TypeScript (#5727) 8509f46 - chore: migrate src/Accessibility to TypeScript (#5726) 930cc32 - chore: migrate src/Errors to TypeScript (#5725) 30aff82 - chore: migrate src/Events to TypeScript (#5724) 1823828 - chore: migrate src/Tracing to TypeScript (#5723) 3050196 - fix: update clipboard read write permissions after upstream change (#5721) 0731049 - chore: update pngjs to 5.0.0 and jpeg-js to 0.3.7 (#5676) ddb8ba1 - chore: tidy up and de-duplicate Travis CI config (#5716) 9d297f0 - chore: bump version to 3.0.1-post (#5717) be8f8a2 - chore: add macOS to Travis CI (#5708) 133abb0 - chore: migrate src/Input to typescript (#5710) 11bc5a6 - chore: migrate src/Worker to typescript (#5715)

v3.0.1

Highlights

  • File uploads should be more reliable now (#5655)
  • The size of the final package is smaller as we explicitly list files to publish (#5659).
  • The docs now include the libgbm-dev dependency that's needed for Linux builds (#5667, #5693)

Behind the scenes

  • We're continuing to migrate to TypeScript and many files within src/ are now TypeScript files. We're working towards a 100% TS codebase which will enable us (amongst other things) to ship high-quality type definitions for TypeScript users.

Raw notes

6029fdd - chore: mark version v3.0.1 (#5709) 29ebd0b - chore: migrate src/ExecutionContext (#5705) 69bfa80 - docs(api): fix typo (#5706) 8d5d76e - chore: migrate src/JSHandle to TS (#5703)

... (truncated)
Commits
Maintainer changes

This version was pushed to npm by jackfranklin, a new releaser for puppeteer since your current version.


Dependabot compatibility score

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.


Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)
  • @dependabot use these labels will set the current labels as the default for future PRs for this repo and language
  • @dependabot use these reviewers will set the current reviewers as the default for future PRs for this repo and language
  • @dependabot use these assignees will set the current assignees as the default for future PRs for this repo and language
  • @dependabot use this milestone will set the current milestone as the default for future PRs for this repo and language
  • @dependabot badge me will comment on this PR with code to add a "Dependabot enabled" badge to your readme

Additionally, you can set the following in your Dependabot dashboard:

  • Update frequency (including time of day and day of week)
  • Pull request limits (per update run and/or open at any time)
  • Out-of-range updates (receive only lockfile updates, if desired)
  • Security updates (receive only security updates, if desired)

@dependabot-preview dependabot-preview bot requested a review from a team as a code owner April 28, 2020 12:25
@dependabot-preview dependabot-preview bot added dependencies Pull requests that update a dependency file javascript Pull requests that update Javascript code labels Apr 28, 2020
@dependabot-preview dependabot-preview bot force-pushed the dependabot-npm_and_yarn-puppeteer-3.0.2 branch 4 times, most recently from 13061b5 to e136146 Compare April 30, 2020 18:34
@havenchyk
Copy link
Contributor

puppeteer doesn't work with node 14 at the moment puppeteer/puppeteer#5719

@havenchyk havenchyk force-pushed the dependabot-npm_and_yarn-puppeteer-3.0.2 branch from ac87094 to 1f4263f Compare May 1, 2020 05:15
@toptal-devbot
Copy link
Collaborator

🎉 Last commit is successfully deployed 🎉

Demo is available on:

Your davinci-bot 🚀

@havenchyk
Copy link
Contributor

havenchyk commented May 1, 2020

So chrome changed the logic of making screenshots, from v2 of puppeteer clip area is limited by the viewport.

So current problems that can be solved in the scope of this PR:

  • reset viewport to be able to make a screenshot of the clipped area instead of viewport only (maybe use full page screenshot?)'
  • try to replace puppeteer with puppeteer-core and remove env variables PUPPETEER_* from docker, check if it works
  • update jest-image-snapshot and check performance
  • try to use babel instead of ts-jest ts->js transpilation and check if it makes a difference - might be related Do not run type check in visual tests #1194

@dependabot-preview
Copy link
Contributor Author

A newer version of puppeteer exists, but since this PR has been edited by someone other than Dependabot I haven't updated it. You'll get a PR for the updated version as normal once this PR is merged.

@denieler
Copy link
Collaborator

denieler commented Jul 8, 2020

@dependabot recreate

@dependabot-preview
Copy link
Contributor Author

Superseded by #1420.

@dependabot-preview dependabot-preview bot deleted the dependabot-npm_and_yarn-puppeteer-3.0.2 branch July 8, 2020 07:04
@havenchyk havenchyk restored the dependabot-npm_and_yarn-puppeteer-3.0.2 branch July 8, 2020 08:42
@havenchyk havenchyk reopened this Jul 8, 2020
ENV APK_BRANCH ${APK_BRANCH}

ENV PATH="${PATH}:/app/node_modules/.bin"

# Installs Chromium (77) package.
# Installs Chromium (81) package.
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I find this comment misleading, tbh. The next line sets an environment variable how is this installation fo chromium and is it reliable to mention the exect number in the comment?

@anym0us anym0us requested review from a team, havenchyk and teimurjan and removed request for a team August 17, 2021 19:44
@TomasSlama TomasSlama closed this Oct 20, 2021
@dependabot-preview
Copy link
Contributor Author

OK, I won't notify you again about this release, but will get in touch when a new version is available.

If you change your mind, just re-open this PR and I'll resolve any conflicts on it.

@dependabot-preview dependabot-preview bot deleted the dependabot-npm_and_yarn-puppeteer-3.0.2 branch October 20, 2021 11:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file javascript Pull requests that update Javascript code
Projects
None yet
5 participants