New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(deps-dev): bump puppeteer from 1.19.0 to 3.0.2 #1265
chore(deps-dev): bump puppeteer from 1.19.0 to 3.0.2 #1265
Conversation
13061b5
to
e136146
Compare
puppeteer doesn't work with node 14 at the moment puppeteer/puppeteer#5719 |
Bumps [puppeteer](https://github.com/puppeteer/puppeteer) from 1.19.0 to 3.0.2. - [Release notes](https://github.com/puppeteer/puppeteer/releases) - [Commits](puppeteer/puppeteer@v1.19.0...v3.0.2) Signed-off-by: dependabot-preview[bot] <support@dependabot.com>
ac87094
to
1f4263f
Compare
🎉 Last commit is successfully deployed 🎉 Demo is available on: Your davinci-bot 🚀 |
So chrome changed the logic of making screenshots, from v2 of puppeteer clip area is limited by the viewport. So current problems that can be solved in the scope of this PR:
|
A newer version of puppeteer exists, but since this PR has been edited by someone other than Dependabot I haven't updated it. You'll get a PR for the updated version as normal once this PR is merged. |
@dependabot recreate |
Superseded by #1420. |
ENV APK_BRANCH ${APK_BRANCH} | ||
|
||
ENV PATH="${PATH}:/app/node_modules/.bin" | ||
|
||
# Installs Chromium (77) package. | ||
# Installs Chromium (81) package. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I find this comment misleading, tbh. The next line sets an environment variable how is this installation fo chromium and is it reliable to mention the exect number in the comment?
OK, I won't notify you again about this release, but will get in touch when a new version is available. If you change your mind, just re-open this PR and I'll resolve any conflicts on it. |
This pull request was created by Dependabot Preview, and you've upgraded to Dependabot. This means it won't respond to
dependabot
commands nor will it be automatically closed if a new version is found.If you close this pull request, Dependabot will re-create it the next time it checks for updates and everything will work as expected.
READ ME FIRST!!!
=====================================================
Bumps puppeteer from 1.19.0 to 3.0.2.
Release notes
Sourced from puppeteer's releases.
Commits
646f42e
chore: mark version v3.0.2 (#5752)3911836
chore: small CI tidy ups (#5751)5e2a029
chore: use Node's promisify function (#5748)1b9d9e9
chore: log useful error for Node v14 breakage (#5732)a7d2485
chore: split out CI into unit tests + extra checks (#5749)3ed2f6b
chore: remove puppeteer-web (#5750)1358b45
chore: migrate src/LifecycleWatcher (#5734)79e82e5
fix: make uploadFile throw for non-existent files (#5733)1a4e260
chore: migrate src/BrowserFetcher to TypeScript (#5727)8509f46
chore: migrate src/Accessibility to TypeScript (#5726)Maintainer changes
This version was pushed to npm by jackfranklin, a new releaser for puppeteer since your current version.
Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting
@dependabot rebase
.Dependabot commands and options
You can trigger Dependabot actions by commenting on this PR:
@dependabot rebase
will rebase this PR@dependabot recreate
will recreate this PR, overwriting any edits that have been made to it@dependabot merge
will merge this PR after your CI passes on it@dependabot squash and merge
will squash and merge this PR after your CI passes on it@dependabot cancel merge
will cancel a previously requested merge and block automerging@dependabot reopen
will reopen this PR if it is closed@dependabot close
will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually@dependabot ignore this major version
will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this minor version
will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this dependency
will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)@dependabot use these labels
will set the current labels as the default for future PRs for this repo and language@dependabot use these reviewers
will set the current reviewers as the default for future PRs for this repo and language@dependabot use these assignees
will set the current assignees as the default for future PRs for this repo and language@dependabot use this milestone
will set the current milestone as the default for future PRs for this repo and language@dependabot badge me
will comment on this PR with code to add a "Dependabot enabled" badge to your readmeAdditionally, you can set the following in your Dependabot dashboard: