Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CI-3421] Move Trigger build image job step to GHA #4296

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

jcobarreto
Copy link
Contributor

@jcobarreto jcobarreto commented May 10, 2024

CI-3421

Description

Move Trigger build image job step from Jenkins to GitHub actions.

Pre-merge checklist

  • The PR relates to a single subject with a clear title and description in grammatically correct, complete sentences.
  • Squash related commits together.
PR commands

List of available commands:

  • @toptal-bot run package:alpha-release - Release alpha version
  • @toptal-anvil ping reviewers - Ping FX team for review
PR Review Guidelines

When to approve? ✅

You are OK with merging this PR and

  1. You have no extra requests.
  2. You have optional requests.
    1. Add nit: to your comment. (ex. nit: I'd rename this variable from makeCircle to getCircle)

When to request changes? ❌

You are not OK with merging this PR because

  1. Something is broken after the changes.
  2. Acceptance criteria is not reached.
  3. Code is dirty.

When to comment (neither ✅ nor ❌)

You want your comments to be addressed before merging this PR in cases like:

  1. There are leftovers like unnecessary logs, comments, etc.
  2. You have an opinionated comment regarding the code that requires a discussion.
  3. You have questions.

How to handle the comments?

  1. An owner of a comment is the only one who can resolve it.
  2. An owner of a comment must resolve it when it's addressed.
  3. A PR owner must reply with ✅ when a comment is addressed.

@jcobarreto jcobarreto added the WIP Work in Progress (Don't review) label May 10, 2024
@jcobarreto jcobarreto self-assigned this May 10, 2024
Copy link

changeset-bot bot commented May 10, 2024

⚠️ No Changeset found

Latest commit: 62b315a

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@jcobarreto jcobarreto force-pushed the ci-3421-move-build-image-to-gha branch 5 times, most recently from 98f80ee to 8a57d94 Compare May 10, 2024 13:48
"IMAGE_NAME": "${{ env.REPOSITORY_NAME }}"
}
job_timeout: "7200"
- uses: docker/setup-buildx-action@v3
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jcobarreto jcobarreto force-pushed the ci-3421-move-build-image-to-gha branch 10 times, most recently from da8d94d to 1ec6b16 Compare May 16, 2024 14:23
@jcobarreto jcobarreto force-pushed the ci-3421-move-build-image-to-gha branch from 1ec6b16 to 62b315a Compare May 28, 2024 13:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
WIP Work in Progress (Don't review)
Projects
None yet
2 participants